eschutho commented on code in PR #33155:
URL: https://github.com/apache/superset/pull/33155#discussion_r2049794314


##########
superset/migrations/shared/utils.py:
##########
@@ -312,6 +312,10 @@ def add_columns(table_name: str, *columns: Column) -> None:
     :param columns: A list of SQLAlchemy Column objects that define the name, 
type, and other attributes of the columns to be added.
     """  # noqa: E501
 
+    if not has_table(table_name=table_name):

Review Comment:
   I was on the fence on that as well, so I removed it. Sounds good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to