geido opened a new pull request, #33205:
URL: https://github.com/apache/superset/pull/33205

   …table behavior
   
   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   This PR https://github.com/apache/superset/pull/33096 introduced a creatable 
configuration for Select. However, default filters would reset when changing 
the option. This PR should fix the issue while also fixing the warning icon 
that looked off.
   
   ### BEFORE
   
   
https://github.com/user-attachments/assets/c2b4d65e-c334-4084-b439-839d44b87cdf
   
   ### AFTER
   
   
https://github.com/user-attachments/assets/7b5a0639-f1d3-4246-a7b4-5fe7223ee39c
   
   ### TESTING INSTRUCTIONS
   1. Open a Dashboard and set a native filter with default values
   2. Toggle the creatable behavior on and off
   3. Default values should stay
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to