Abhishek-kumar-samsung commented on PR #33204: URL: https://github.com/apache/superset/pull/33204#issuecomment-2822994595
> LGTM, but I wonder if we should replace the existing component with a Select (configured to let you add custom values) rather than adding an input to the current component (which looks like a bit of a design system outlier). @geido or @kasiazjc might have additional opinions here. In select too, i would have implemented in same fashion because rest options in dropdown are just clickable and this one is customized to take input, thats why i didn't changed existing implementation of dropdown from Menu to Select, just added a new Input field as a new menu item in current Menu. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
