Vitor-Avila commented on PR #33196: URL: https://github.com/apache/superset/pull/33196#issuecomment-2829259692
@LevisNgigi thank you so much for taking the time to implement these fixes! 🙏 I tested the flow again and: - Big Numbers with Trendline seem to be working properly. ✅ - Existing Big Numbers are no longer showing both `subheader` and `subtitle` in the dashboard view. Just one is displayed. ✅ - Accessing these Big Numbers in Explore shows a single entry as well. ✅ - Accessing these Big Numbers in Explore defaults the subtitle size to the default value (**Small**) as opposed to respecting the old value from subheader. 🔴 I suggested a potential fix for this remaining issue, but I didn't want to commit it as I want your thoughts on it first. If you're comfortable with it, feel free to push it to this branch and I can do one final round of tests. 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
