EnxDev commented on code in PR #33256:
URL: https://github.com/apache/superset/pull/33256#discussion_r2064039788
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/Option.tsx:
##########
@@ -72,9 +72,13 @@ export default function Option({
<Label data-test="control-label">{children}</Label>
{(!!datasourceWarningMessage || isExtra) && (
<StyledInfoTooltipWithTrigger
- icon="exclamation-triangle"
+ icon={
Review Comment:
I can standardize the color and font-size: for example, I could have three
types:
- default with grayscale color and 12 px
- error with error color and 12 px
- warning with warning color and 12 px
We would need to know which icon you want, right?
For example, I could have ExclamationCircleOutlined in yellow or grayscale,
or I could have
InfoCircleOutlined in yellow or red.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
