mistercrunch commented on code in PR #33216:
URL: https://github.com/apache/superset/pull/33216#discussion_r2064044812


##########
pyproject.toml:
##########
@@ -64,6 +64,7 @@ dependencies = [
     "jsonpath-ng>=1.6.1, <2",
     "Mako>=1.2.2",
     "markdown>=3.0",
+    "marshmallow<4",

Review Comment:
   Let's always put a comment above when setting an upper bound that's not 
based on pure semver assumptions, something like "marshmallow>=4 has shows 
issues related to `'minLength'`", ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to