mistercrunch commented on code in PR #33287:
URL: https://github.com/apache/superset/pull/33287#discussion_r2067564098
##########
superset-frontend/src/components/Icons/BaseIcon.tsx:
##########
@@ -46,14 +46,12 @@ export const BaseIconComponent: React.FC<
...rest
}) => {
const theme = useTheme();
- const iconCss = css`
- color: ${iconColor || theme.colorIcon};
Review Comment:
This was preventing some magic to happen in the Button component that aligns
icons with the button style
##########
superset-frontend/src/components/Icons/BaseIcon.tsx:
##########
@@ -46,14 +46,12 @@ export const BaseIconComponent: React.FC<
...rest
}) => {
const theme = useTheme();
- const iconCss = css`
- color: ${iconColor || theme.colorIcon};
Review Comment:
NOET: this was preventing some magic to happen in the Button component that
aligns icons with the button style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
