justinpark commented on PR #33341: URL: https://github.com/apache/superset/pull/33341#issuecomment-2847790598
> and the fact that the dialect will not be generic most of the time, I wonder if we should always format the SQL when visualizing the query. To be clear, I'm not proposing reverting betodealmeida's changes but to always format the SQL when clicking on View query. I like the idea too. Since the formatted SQL in this section doesn't modify the original SQL, it should be okay. Additionally, I plan to display a "Show Original" button so that users can revert back to the original SQL if needed, allowing access to both versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
