Re: [PR] fix(embedded): handle SUPERSET_APP_ROOT in embedded dashboard URLs [superset]

[via GitHub]

korbit-ai[bot] commented on code in PR #33356:
URL: https://github.com/apache/superset/pull/33356#discussion_r2072809946


##########
superset-frontend/src/embedded/index.tsx:
##########
@@ -41,6 +41,7 @@ setupPlugins();
 
 const debugMode = process.env.WEBPACK_MODE === 'development';
 const bootstrapData = getBootstrapData();
+const appRootPath = process.env.SUPERSET_APP_ROOT || '';

Review Comment:
   ### Unclear Default Value Intent <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Using empty string as a fallback for SUPERSET_APP_ROOT lacks clarity about 
the default behavior.
   
   ###### Why this matters
   Without explicit default value documentation, future developers may not 
understand why an empty string was chosen as the fallback and what impact it 
has on URL construction.
   
   ###### Suggested change ∙ *Feature Preview*
   ```typescript
   // Default to empty string for root path when SUPERSET_APP_ROOT is not set
   const appRootPath = process.env.SUPERSET_APP_ROOT || '';
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c74e98ed-8deb-4f20-bcfc-f8847124136a/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c74e98ed-8deb-4f20-bcfc-f8847124136a?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c74e98ed-8deb-4f20-bcfc-f8847124136a?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c74e98ed-8deb-4f20-bcfc-f8847124136a?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/c74e98ed-8deb-4f20-bcfc-f8847124136a)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:2baaa577-4bc0-4480-97c4-d903d1ae0fb6 -->
   
   
   [](2baaa577-4bc0-4480-97c4-d903d1ae0fb6)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org