betodealmeida commented on PR #33357: URL: https://github.com/apache/superset/pull/33357#issuecomment-2854797673
Taking a look now, but a few initial comments: 1. In general, any PR that changes the UI/UX significantly should go [through a discussion](https://github.com/apache/superset/issues/5602). For uncontroversial changes the process is usually quick, since you can request "lazy consensus" and people don't have to vote. I think we're OK in this one, just letting you know for the future. 2. Splitting the PR into 4 would've been better, even if it takes more time/work upfront. It makes reviews quicker and it's simpler to revert features if something goes wrong. 3. I'm a bit concerned about the performance of the `LIKE` search, and wondering if we should have optional ways of optimizing it, but let me look at the PR in details before we start worrying about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
