mistercrunch commented on code in PR #33364:
URL: https://github.com/apache/superset/pull/33364#discussion_r2078586348
##########
superset/viz.py:
##########
@@ -1532,7 +1532,31 @@ def get_data(self, df: pd.DataFrame) -> VizData:
slice_ids = self.form_data.get("deck_slices")
slices = db.session.query(Slice).filter(Slice.id.in_(slice_ids)).all()
+
+ features: dict[str, list[Any]] = {}
Review Comment:
noting that we're trying to deprecate `viz.py` in favor of
`/api/v1/chart/data`, though might be out-of-scope for this PR. I think some
visualization like the deck.gl ones will need to migrate to the chart/data
endpoint eventually. Pilling on more stuff onto viz.py might make it harder to
migrate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
