Copilot commented on code in PR #33145: URL: https://github.com/apache/superset/pull/33145#discussion_r2078676283
########## superset-frontend/packages/superset-ui-core/src/components/AlteredSliceTag/index.tsx: ########## @@ -23,11 +23,7 @@ import { t } from '@superset-ui/core'; import { sanitizeFormData } from 'src/explore/exploreUtils/formData'; import getControlsForVizType from 'src/utils/getControlsForVizType'; import { safeStringify } from 'src/utils/safeStringify'; -import { Icons } from 'src/components/Icons'; -import { Label } from '../Label'; -import { Tooltip } from '../Tooltip'; -import ModalTrigger from '../ModalTrigger'; -import TableView from '../TableView'; +import { ModalTrigger, Icons, Label, Tooltip, TableView } from '..'; Review Comment: [nitpick] Consolidating multiple component imports via an index file improves maintainability; however, it could potentially import unused code, which may affect bundle size. Consider evaluating whether explicit imports would be more appropriate if tree shaking is a priority. ```suggestion import ModalTrigger from '../ModalTrigger'; import Icons from '../Icons'; import Label from '../Label'; import Tooltip from '../Tooltip'; import TableView from '../TableView'; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org