betodealmeida commented on code in PR #33473:
URL: https://github.com/apache/superset/pull/33473#discussion_r2093303619
##########
tests/unit_tests/db_engine_specs/test_mssql.py:
##########
@@ -254,36 +254,6 @@ def test_cte_query_parsing(original: TypeEngine, expected:
str) -> None:
assert actual == expected
[email protected](
- "original,expected,top",
- [
- ("SEL TOP 1000 * FROM My_table", "SEL TOP 100 * FROM My_table", 100),
- ("SEL TOP 1000 * FROM My_table;", "SEL TOP 100 * FROM My_table", 100),
- ("SEL TOP 1000 * FROM My_table;", "SEL TOP 1000 * FROM My_table",
10000),
- ("SEL TOP 1000 * FROM My_table;", "SEL TOP 1000 * FROM My_table",
1000),
Review Comment:
This is invalid syntax... MS SQL doesn't support the `SEL` shortcut for
`SELECT`!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
