LevisNgigi commented on PR #33407: URL: https://github.com/apache/superset/pull/33407#issuecomment-2887832628
> Oh so there are some mechanics behind there that will run 2 queries? I know we do that in some special cases like maybe "show totals" in the Table visualization (?) > > Now wondering if we should use this new option as the default of keep LAST_VALUE there (?) Seems generally users would expect LAST_VALUE, but I might not be the right person to decide since I probably built it the way it is today as it seems more intuitive to me... Yes,this setup runs two queries: one for the trendline and another for the big number when no aggregation method is selected. With the new change making aggregation optional, we can't assign a different default like LAST_VALUE, since doing so would prevent users from clearing the selection and reverting to the raw metric. Leaving the control empty is now the explicit signal to compute the raw value across the entire time range.Yes,Last value was previously the default, I hope the new option is okay? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
