mistercrunch opened a new pull request, #33501: URL: https://github.com/apache/superset/pull/33501
Recently noticed that in Explore, loading popovers for metrics, columns, and filters take forever to load. Upon inspection it had to do with a call to `react-dom/server`'s `renderToStaticMarkup` which isn't meant to be used on the client, more of a server thing. The goal was to align tooltips in AceEditor (which use native html) with AntD's. For that we would pass an antd Tooltip to a server-side like component to generate html, which is super slow and uneficient. My solution is to generate the html directly. Not great, fancy, or future-proof but fast. Plan is probably to move off Ace and onto Monaco... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
