korbit-ai[bot] commented on code in PR #33540:
URL: https://github.com/apache/superset/pull/33540#discussion_r2097751432
##########
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx:
##########
@@ -343,6 +343,26 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'order_desc',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Sort descending'),
+ default: true,
+ description: t(
+ 'If enabled, this control sorts the results/values descending,
otherwise it sorts the results ascending.',
+ ),
+ visibility: ({ controls }: ControlPanelsContainerProps) => {
+ const hasSortMetric = Boolean(
+ controls?.timeseries_limit_metric?.value,
+ );
+ return hasSortMetric && isAggMode({ controls });
+ },
Review Comment:
Could you help me understand - is there a reason why Sort Descending
shouldn't apply to Raw mode ordering? The UI currently allows ordering columns
in Raw mode but without control over the direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
