Darth-ATA opened a new pull request, #33541: URL: https://github.com/apache/superset/pull/33541
### SUMMARY Previously, when Server-side pagination was enabled, the “Export to full .CSV” button behaved the same as “Export to .CSV”, exporting only the currently visible page (e.g., 50 rows), instead of the entire dataset. This PR updates Chart.jsx to ensure that the pageSize and currentPage parameters are omitted from the full export request, allowing the “Export to full .CSV” action to retrieve and export the complete dataset as expected. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF - Before: Clicking “Export to full .CSV” with server pagination enabled only exported the current page (e.g., 50 rows).  - After: Clicking “Export to full .CSV” exports the entire dataset, regardless of the current page size.  ### TESTING INSTRUCTIONS 1. Go to `Games` chart whose have more than one page of rows (e.g., >100 rows). 2. Enable Server-side pagination and set Server Page Length to 50. 3. Save it as `Games Server pagination`. 4. Add it to the `Video Games Salse` dashboard as `Games Server pagination` 3. Click “Export to full .CSV”. - Before this change: Only 50 rows are exported. - After this change: All rows in the dataset are exported. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
