Re: [PR] fix(Sqllab): Autocomplete got stuck in UI when open it too fast [superset]

Tue, 20 May 2025 07:29:13 -0700 


korbit-ai[bot] commented on code in PR #33522:
URL: https://github.com/apache/superset/pull/33522#discussion_r2098131750


##########
superset-frontend/src/SqlLab/components/SqlEditor/index.tsx:
##########
@@ -325,6 +325,8 @@ const SqlEditor: FC<Props> = ({
 
   const SqlFormExtension = extensionsRegistry.get('sqleditor.extension.form');
 
+  const isTempId = (value: unknown): boolean => Number.isNaN(Number(value));

Review Comment:
   ### Incorrect Temporary ID Detection Logic <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The function incorrectly identifies temporary IDs. Non-numeric strings will 
be considered temporary IDs, but numeric strings will be considered 
non-temporary.
   
   
   ###### Why this matters
   This can lead to false positives and false negatives in ID validation, 
causing autocomplete to be incorrectly enabled/disabled for certain IDs.
   
   ###### Suggested change ∙ *Feature Preview*
   Change the implementation to correctly identify temporary IDs based on their 
expected format. A more accurate implementation would be:
   ```typescript
   const isTempId = (value: unknown): boolean => {
     if (typeof value !== 'string') return false;
     return value.startsWith('temp_');
   }
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/ba143c54-692e-4161-869c-11c0e259ef1b/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/ba143c54-692e-4161-869c-11c0e259ef1b?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/ba143c54-692e-4161-869c-11c0e259ef1b?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/ba143c54-692e-4161-869c-11c0e259ef1b?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/ba143c54-692e-4161-869c-11c0e259ef1b)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:2b5a50e6-5967-47e3-8bd3-c7d6448b81e6 -->
   
   
   [](2b5a50e6-5967-47e3-8bd3-c7d6448b81e6)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to