rusackas commented on issue #33012: URL: https://github.com/apache/superset/issues/33012#issuecomment-2898536592
I like it, and it doesn't sound like there are any show-stoppers from anyone we've spoken with at Preset or Airbnb in the (public) SIP review session. The thing to consider here (for others) is that we need to spread this far and wide, so basically _anywhere_ you enter a query, you can leverage a Saved Query like this. Conversely, if you enter your own query here, should it be Saved as a Saved Query, too (or at least provide the option to do so)? Maybe it works both ways? The other open question is how we treat Saved Queries in terms of ownership... we not only want to support the author's saved queries, but letting Saved Queries have multiple owners, as a primary asset in Superset. That would be another SIP, but it's related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
