Re: [PR] feat(slack): Add Slack unfurl metadata for dashboards [superset]

Wed, 21 May 2025 11:28:42 -0700 


korbit-ai[bot] commented on code in PR #33550:
URL: https://github.com/apache/superset/pull/33550#discussion_r2100906986


##########
superset/templates/superset/spa.html:
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_meta %}
+  {% if title %}<meta property="og:title" content="{{ title }}" />{% endif %}

Review Comment:
   ### Inconsistent Meta Tag Formatting <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The meta tag for og:title is written as a single line conditional, making it 
inconsistent with the formatting of the other meta tags and harder to scan.
   
   
   ###### Why this matters
   Inconsistent formatting across similar elements makes the code harder to 
read and maintain. Visual consistency helps developers quickly understand the 
structure.
   
   ###### Suggested change ∙ *Feature Preview*
   ```html
     {% if title %}
       <meta property="og:title" content="{{ title }}" />
     {% endif %}
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/79720db0-b493-4268-ab0c-d83e39d98270/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/79720db0-b493-4268-ab0c-d83e39d98270?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/79720db0-b493-4268-ab0c-d83e39d98270?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/79720db0-b493-4268-ab0c-d83e39d98270?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/79720db0-b493-4268-ab0c-d83e39d98270)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:c90b5e1a-1cc7-415c-9c65-5a67cff4c7ed -->
   
   
   [](c90b5e1a-1cc7-415c-9c65-5a67cff4c7ed)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to