msyavuz commented on code in PR #33559:
URL: https://github.com/apache/superset/pull/33559#discussion_r2107642369
##########
superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts:
##########
@@ -111,20 +128,46 @@ export default function transformProps(
const { setDataMask = () => {}, onContextMenu } = hooks;
const colorFn = CategoricalColorNamespace.getScale(colorScheme as string);
const numberFormatter = getNumberFormatter(numberFormat);
+ const denormalizedSeriesValues: SeriesNormalizedMap = {};
+
+ const getDenormalizedSeriesValue = (
+ seriesName: string,
+ normalizedValue: string,
+ ): number =>
+ denormalizedSeriesValues?.[seriesName]?.[normalizedValue] ??
+ Number(normalizedValue);
+
+ const metricLabels = metrics.map(getMetricLabel);
+
const formatter = (params: CallbackDataParams) =>
formatLabel({
params,
numberFormatter,
labelType,
+ getDenormalizedSeriesValue,
+ metricsWithCustomBounds,
Review Comment:
I thought we have no-use-before-define configured, this is used before it
was defined, we can just move definition above usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
