mistercrunch commented on a change in pull request #7032: Fetch charts with GET
to benefit from browser cache and conditional requests
URL:
https://github.com/apache/incubator-superset/pull/7032#discussion_r288412133
##########
File path: superset/views/core.py
##########
@@ -100,6 +101,46 @@ def is_owner(obj, user):
return obj and user in obj.owners
+def check_datasource_perms(self, datasource_type=None, datasource_id=None):
+ """
+ Check if user can access a cached response from explore_json.
+
+ This function takes `self` since it must have the same signature as the
+ the decorated method.
+
+ """
+ form_data = get_form_data()[0]
+ datasource_id, datasource_type = get_datasource_info(
+ datasource_id, datasource_type, form_data)
+ viz_obj = get_viz(
+ datasource_type=datasource_type,
+ datasource_id=datasource_id,
+ form_data=form_data,
+ force=False,
+ )
+ security_manager.assert_datasource_permission(viz_obj.datasource)
+
+
+def check_slice_perms(self, slice_id):
+ """
+ Check if user can access a cached response from slice_json.
+
+ This function takes `self` since it must have the same signature as the
+ the decorated method.
+
+ """
+ form_data, slc = get_form_data(slice_id, use_slice_data=True)
+ datasource_type = slc.datasource.type
+ datasource_id = slc.datasource.id
+ viz_obj = get_viz(
Review comment:
I think `get_viz` gets called at least two times now (here and in the view
itself)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
