betodealmeida commented on code in PR #33568:
URL: https://github.com/apache/superset/pull/33568#discussion_r2115913810
##########
superset/sql/dialects/firebolt.py:
##########
@@ -168,9 +141,6 @@ def join_sql(self, expression: exp.Join) -> str:
this = expression.this
this_sql = self.sql(this)
- if exprs := self.expressions(expression):
- this_sql = f"{this_sql},{self.seg(exprs)}"
Review Comment:
I added tests covering all the syntax in [the
docs](https://old.docs.firebolt.io/sql-reference/commands/select.html) and
never hit this line. Looked at `sqlglot` tests and there were only 2 queries in
their suite that hit this line, and they were not supported by Firebolt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
