mistercrunch commented on code in PR #32556:
URL: https://github.com/apache/superset/pull/32556#discussion_r2118418989
##########
tests/integration_tests/db_engine_specs/base_engine_spec_tests.py:
##########
@@ -196,7 +197,11 @@ def test_engine_time_grain_validity(self):
time_grains = set(builtin_time_grains.keys())
# loop over all subclasses of BaseEngineSpec
for engine in load_engine_specs():
- if engine is not BaseEngineSpec:
+ if (
Review Comment:
for unit tests, if they dependencies on external drivers (pyodps in this
case) , there's a decorator for conditional unit tests that run only when the
dependency is there. Currently we only install some of the database drivers in
our CI builds (the ones that end up in development.txt). Most likely we don't
want to install all possible drivers and run unit tests against it because
there's just too many databases and drivers for the core maintainers to
manage... Many drivers are finicky, and some drivers/integrations only few
people care about.
Anyhow, not a bad thing to have unit tests in the repo, but won't run as
part of our CI. Maybe in your fork/CI you can run tests that are odps-specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
