Re: [PR] chore: move backend under superset-backend [superset]

Sun, 08 Jun 2025 16:26:26 -0700 


korbit-ai[bot] commented on code in PR #33722:
URL: https://github.com/apache/superset/pull/33722#discussion_r2134854335


##########
.github/workflows/bashlib.sh:
##########
@@ -109,7 +109,7 @@ testdata() {
   say "::group::Load test data"
   # must specify PYTHONPATH to make `tests.superset_test_config` importable
   export PYTHONPATH="$GITHUB_WORKSPACE"
-  pip install -e .
+  pip install -e superset-backend/.

Review Comment:
   ### Missing directory existence check <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The path to the backend installation has been changed but no verification is 
done to ensure the directory exists before attempting installation.
   
   
   ###### Why this matters
   If the 'superset-backend' directory is missing or not properly relocated, 
the pip install command will fail, breaking the test data loading process and 
subsequent operations.
   
   ###### Suggested change ∙ *Feature Preview*
   Add a directory check before pip installation:
   ```bash
   if [ ! -d "superset-backend" ]; then
     echo "Error: superset-backend directory not found"
     exit 1
   fi
   pip install -e superset-backend/.
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/40328053-b97f-4389-afa9-b5163181fabd/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/40328053-b97f-4389-afa9-b5163181fabd?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/40328053-b97f-4389-afa9-b5163181fabd?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/40328053-b97f-4389-afa9-b5163181fabd?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/40328053-b97f-4389-afa9-b5163181fabd)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:566cefb1-6ffa-44a8-a468-3109d3a071bc -->
   
   
   [](566cefb1-6ffa-44a8-a468-3109d3a071bc)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to