ERGO1995 commented on code in PR #31646: URL: https://github.com/apache/superset/pull/31646#discussion_r2144454644
########## superset/config.py: ########## @@ -311,6 +301,22 @@ def _try_json_readsha(filepath: str, length: int) -> str | None: # Specify the App icon APP_ICON = "/static/assets/images/superset-logo-horiz.png" +# Multiple favicons can be specified here. The "href" property +# is mandatory, but "sizes," "type," and "rel" are optional. +# For example: +# { +# "href":path/to/image.png", +# "sizes": "16x16", +# "type": "image/png" +# "rel": "icon" +# }, +FAVICONS = [{"href": "/static/assets/images/favicon.png"}] Review Comment: mixing code with custom loaders, my bad -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org