EnxDev opened a new pull request, #33826: URL: https://github.com/apache/superset/pull/33826
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The primary goal of this PR is to fix the visual bugs currently affecting the Database Modal form. I’ve improved the functionality introduced in #14530 by adding an additional validation status, `validating`, to provide better feedback to users when the validation API call takes longer than expected. I also aimed to clearly separate client-side validation from server-side validation to offer a more modern user experience. Additionally, I’ve disabled the "Connect" submit button unless the form is error-free, effectively preventing unnecessary API calls for database connection attempts. This implementation can be considered a hybrid approach. While it improves the current state, there are certainly better ways to further decouple validations and manage state; for example, tracking which field is currently being validated. This would allow for more precise error feedback, especially when using `onBlur`. However, addressing that is out of scope for this PR. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - All tests should pass - To reproduce the issue, follow the video in the BEFORE/AFTER section ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
