nathanjrobertson opened a new pull request, #33837:
URL: https://github.com/apache/superset/pull/33837

   ### SUMMARY
   When using a self hosted PostgreSQL (eg. cloud vendor hosted), they often 
require extra parameters for the SQLAlchemy URI string. In my case, my vendor 
requires "sslmode=require". However, I respect that other users might have 
other parameters they need to pass, so I haven't hardcoded an "SSL" flag, but 
instead provided a generic connection parameters option.
   
   The new `supersetNode.connections.db_conn_params` option is commented out by 
default (ie. defaults to `nil`), which makes this change backward compatible. 
The commented out value provided in `values.yaml` shows how to enable SSL 
(which I expect is the most common use case for this feature).
   
   ### TESTING INSTRUCTIONS
   
   1. Setup PostgreSQL server with SSL support enabled
   2. In `values.yaml`, set `supersetNode.connections.db_conn_params: 
"sslmode=require"`
   3. Install Helm chart.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [X] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to