Re: [PR] build(deps): remove legacy browser polyfills [superset]

Sat, 21 Jun 2025 09:17:37 -0700 


korbit-ai[bot] commented on code in PR #33853:
URL: https://github.com/apache/superset/pull/33853#discussion_r2160075558


##########
superset-frontend/jest.config.js:
##########
@@ -32,7 +32,7 @@ module.exports = {
       '<rootDir>/node_modules/@superset-ui/$1/src/$2',
     '^@superset-ui/([^/]+)$': '<rootDir>/node_modules/@superset-ui/$1/src',
   },
-  testEnvironment: 'jsdom',
+  testEnvironment: '<rootDir>/spec/helpers/jsDomWithFetchAPI.ts',

Review Comment:
   ### Missing Test Environment File Validation <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The Jest configuration points to a test environment file 
(jsDomWithFetchAPI.ts) without verifying its existence or providing a fallback.
   
   
   ###### Why this matters
   If the referenced test environment file is missing or incorrectly 
implemented, all tests will fail to run, breaking the test suite functionality.
   
   ###### Suggested change ∙ *Feature Preview*
   Ensure the jsDomWithFetchAPI.ts file exists in the spec/helpers directory 
and contains proper test environment setup code. A basic implementation should 
look like:
   ```typescript
   const JSDOMEnvironment = require('jest-environment-jsdom').default;
   
   class CustomEnvironment extends JSDOMEnvironment {
     constructor(config) {
       super(config);
       this.global.fetch = fetch;
       this.global.Headers = Headers;
       this.global.Request = Request;
       this.global.Response = Response;
     }
   }
   
   module.exports = CustomEnvironment;
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/7303aa79-9ae0-4b7a-8ece-85181e302921/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/7303aa79-9ae0-4b7a-8ece-85181e302921?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/7303aa79-9ae0-4b7a-8ece-85181e302921?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/7303aa79-9ae0-4b7a-8ece-85181e302921?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/7303aa79-9ae0-4b7a-8ece-85181e302921)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:b1ca0408-7be3-40af-b350-8ba843fe8347 -->
   
   
   [](b1ca0408-7be3-40af-b350-8ba843fe8347)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to