geido commented on code in PR #33851:
URL: https://github.com/apache/superset/pull/33851#discussion_r2160144508
##########
superset/config.py:
##########
@@ -551,19 +551,26 @@ class D3TimeFormat(TypedDict, total=False):
"PLAYWRIGHT_REPORTS_AND_THUMBNAILS": False,
# Set to True to enable experimental chart plugins
"CHART_PLUGINS_EXPERIMENTAL": False,
- # Regardless of database configuration settings, force SQLLAB to run async
using Celery # noqa: E501
+ # Regardless of database configuration settings, force SQLLAB to run async
+ # using Celery
"SQLLAB_FORCE_RUN_ASYNC": False,
# Set to True to to enable factory resent CLI command
"ENABLE_FACTORY_RESET_COMMAND": False,
# Whether Superset should use Slack avatars for users.
# If on, you'll want to add "https://avatars.slack-edge.com"; to the list
of allowed
# domains in your TALISMAN_CONFIG
"SLACK_ENABLE_AVATARS": False,
- # Adds a switch to the navbar to enable/disable the dark theme
- # This is used for development to expose what is dynamic (css-in-js) vs
- # what is managed by `.less` files.
- "DARK_THEME_SWITCH": False,
Review Comment:
I believe this is meant to be the preferred way of switching theme modes and
works independently of the editor. We might want to keep the editor FF false by
default and this default True?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
