korbit-ai[bot] commented on code in PR #33868: URL: https://github.com/apache/superset/pull/33868#discussion_r2161975102
########## superset/db_engine_specs/__init__.py: ########## @@ -33,11 +33,11 @@ import pkgutil from collections import defaultdict from importlib import import_module +from importlib.metadata import entry_points Review Comment: ### Missing Python Version Compatibility Check <sub></sub> <details> <summary>Tell me more</summary> ###### What is the issue? The code assumes Python 3.8+ without explicitly checking Python version compatibility. ###### Why this matters If the application runs on Python < 3.8, it will crash due to the unavailability of importlib.metadata in the standard library. ###### Suggested change ∙ *Feature Preview* Add version check or maintain Python requirement. Either: 1. Add version check: ```python import sys if sys.version_info < (3, 8): from importlib_metadata import entry_points else: from importlib.metadata import entry_points ``` 2. Or ensure Python >= 3.8 requirement is explicitly documented and enforced in project's pyproject.toml/setup.py. ###### Provide feedback to improve future suggestions [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/04b594ef-1b8e-4b51-85ed-6e9fe7de15fa/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/04b594ef-1b8e-4b51-85ed-6e9fe7de15fa?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/04b594ef-1b8e-4b51-85ed-6e9fe7de15fa?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/04b594ef-1b8e-4b51-85ed-6e9fe7de15fa?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/04b594ef-1b8e-4b51-85ed-6e9fe7de15fa) </details> <sub> 💬 Looking for more details? Reply to this comment to chat with Korbit. </sub> <!--- korbi internal id:1fd9d1f1-3947-4f34-8b2c-06fe1911f693 --> [](1fd9d1f1-3947-4f34-8b2c-06fe1911f693) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
