amaannawab923 commented on code in PR #33844:
URL: https://github.com/apache/superset/pull/33844#discussion_r2162902411
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -757,8 +757,6 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
basicColorFormatters.length > 0;
const valueRange =
- !hasBasicColorFormatters &&
- !hasColumnColorFormatters &&
Review Comment:
We cannot remove these conditions , these are necessary conditions to
prevent cell bars in case of Basic Formatting in case of Time Comparision &
Custom Conditional Formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
