mistercrunch opened a new pull request, #33890:
URL: https://github.com/apache/superset/pull/33890

   This PR introduce new `superset_config` settings:
   
   ```
   # THEME and THEME_DARK are used for setting a custom theme to Superset,
   # it follows the ant design theme structure.
   # You can use the AntDesign theme editor to generate a theme structure
   # https://ant.design/theme-editor
   # The config are set as a callable returning an antd-compatible theme object
   # so that themes can be hot-swapped by fetching a theme object definition 
remotely
   
   # Whether to respect the user's OS dark mode setting. If True, THEME_DARK 
must be set
   THEME_RESPECT_USER_OS_DARK_SETTING = False
   THEME: dict[str, Any] = lambda: {}  # NOQA
   THEME_DARK: dict[str, Any] = lambda: {"algorithm": "dark"}  # NOQA
   ```
   
   Some of the logic:
   - the frontend will set a cookie with the os-level prefference for dark theme
   - on first request, before cookie is set, the backend returns both theme 
configuration
     under `boostrapData.themes`, letting the frontend to cho
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to