hainenber commented on code in PR #33895:
URL: https://github.com/apache/superset/pull/33895#discussion_r2166963038
##########
superset/datasets/api.py:
##########
@@ -299,6 +303,32 @@ class DatasetRestApi(BaseSupersetModelRestApi):
list_outer_default_load = True
show_outer_default_load = True
+ def _handle_filters_args(self, rison_args: Dict[str, Any]) -> Filters:
+ """
+ Handle filters arguments passed to the API endpoint.
+
+ Parses and applies filtering criteria provided as Rison-encoded
arguments
+ to construct a Filters instance. This method ensures that each request
+ uses an isolated Filters instance to avoid shared state issues
+ in concurrent or asynchronous environments.
+
+ Example input:
+ rison_args = {
+ "filters": [
+ {"col": "table_name", "opr": "eq", "value": "some_table"}
+ ]
+ }
+ :param rison_args: A dictionary of arguments parsed from the API
request'sAdd commentMore actions
Review Comment:
nit: indent this sentence to be on par with remaining comments
```suggestion
:param rison_args: A dictionary of arguments parsed from the API
request'sAdd commentMore actions
```
##########
superset/datasets/api.py:
##########
@@ -17,18 +17,22 @@
# pylint: disable=too-many-lines
from __future__ import annotations
+import copy
Review Comment:
This import is not being used anywhere. Should be removed
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
