Re: [PR] fix(plugin-chart-echarts): last month doesn't appear on X axis for time series line chart [superset]

Sat, 28 Jun 2025 22:04:10 -0700 


korbit-ai[bot] commented on code in PR #33966:
URL: https://github.com/apache/superset/pull/33966#discussion_r2173598791


##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -505,6 +505,7 @@ export default function transformProps(
       formatter: xAxisFormatter,
       rotate: xAxisLabelRotation,
       interval: xAxisLabelInterval,
+      showMaxLabel: true,

Review Comment:
   ### Horizontal Chart Mode Label Display Issue <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The showMaxLabel property is set unconditionally without considering 
horizontal orientation where axis positions are swapped.
   
   
   ###### Why this matters
   When the chart is in horizontal orientation, the X and Y axes are swapped 
but showMaxLabel remains on the wrong axis, which could result in missing 
labels in horizontal mode.
   
   ###### Suggested change ∙ *Feature Preview*
   Add the showMaxLabel property conditionally based on chart orientation:
   ```typescript
   if (isHorizontal) {
     yAxis = {
       ...yAxis,
       axisLabel: {
         ...yAxis.axisLabel,
         showMaxLabel: true,
       },
     };
   } else {
     xAxis = {
       ...xAxis,
       axisLabel: {
         ...xAxis.axisLabel,
         showMaxLabel: true,
       },
     };
   }
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93f66b1e-df01-4e0e-a61d-96256347545c/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93f66b1e-df01-4e0e-a61d-96256347545c?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93f66b1e-df01-4e0e-a61d-96256347545c?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93f66b1e-df01-4e0e-a61d-96256347545c?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/93f66b1e-df01-4e0e-a61d-96256347545c)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:4320196d-6cae-48e1-b969-faeb9c8b82d0 -->
   
   
   [](4320196d-6cae-48e1-b969-faeb9c8b82d0)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to