Re: [PR] fix(handlebars): remove serverPaginationControlSetRow from control pa… [superset]

Tue, 01 Jul 2025 11:26:45 -0700 


korbit-ai[bot] commented on code in PR #34016:
URL: https://github.com/apache/superset/pull/34016#discussion_r2178276695


##########
superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controlPanel.tsx:
##########
@@ -57,7 +54,7 @@ const config: ControlPanelConfig = {
         [percentMetricsControlSetItem],
         [timeSeriesLimitMetricControlSetItem, orderByControlSetItem],
         [orderDescendingControlSetItem],
-        serverPaginationControlSetRow,
+        // serverPaginationControlSetRow,

Review Comment:
   ### Remove commented-out code <sub>![category 
Readability](https://img.shields.io/badge/Readability-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Commented-out code left in the codebase that has been functionally removed.
   
   
   ###### Why this matters
   Commented-out code creates confusion about whether it might be needed in the 
future and adds unnecessary noise to the codebase. Dead code should be removed 
entirely, as it can be retrieved from version control if needed.
   
   ###### Suggested change ∙ *Feature Preview*
   ```typescript
   // Remove this line entirely:
   // serverPaginationControlSetRow,
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6ec62bb6-e333-479f-a6b6-f0b9a628445e/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6ec62bb6-e333-479f-a6b6-f0b9a628445e?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6ec62bb6-e333-479f-a6b6-f0b9a628445e?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6ec62bb6-e333-479f-a6b6-f0b9a628445e?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6ec62bb6-e333-479f-a6b6-f0b9a628445e)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:d805a050-f4f6-426c-8eb3-30f06173b1ed -->
   
   
   [](d805a050-f4f6-426c-8eb3-30f06173b1ed)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to