geido commented on code in PR #34023:
URL: https://github.com/apache/superset/pull/34023#discussion_r2179689239
##########
superset/initialization/__init__.py:
##########
@@ -286,7 +286,9 @@ def init_views(self) -> None:
label=__("List Roles"),
category="Security",
category_label=__("Security"),
- icon="fa-lock",
+ menu_cond=lambda: bool(
+ appbuilder.app.config.get("SUPERSET_SECURITY_VIEW_MENU", True)
Review Comment:
Can we include this in the main config with a comment of what it does and
default it to True?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
