mistercrunch commented on PR #33204: URL: https://github.com/apache/superset/pull/33204#issuecomment-3028489142
Noting that I believe there is logic to use the `LIMIT` from the SQL-provided code (may not work with `ROWNUM` or `TOP` databases) if it's within the config-allowed range. I haven't looked at the code in years, so things might have changed, but wanted to note that. My expectation is that it'll use the user-provided LIMIT as long as it's smaller than the allowed limit. If adding a new control/setting, we should make sure it also obeys to the same rule, always enforcing the config-defined hard limit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
