sadpandajoe commented on code in PR #34018:
URL: https://github.com/apache/superset/pull/34018#discussion_r2180665158
##########
superset-frontend/packages/superset-ui-core/src/utils/html.tsx:
##########
@@ -35,6 +35,13 @@ const xssFilter = new FilterXSS({
'width',
'muted',
],
+ table: ['width', 'border', 'align', 'valign', 'style'],
+ tr: ['rowspan', 'align', 'valign', 'style'],
+ td: ['width', 'rowspan', 'colspan', 'align', 'valign', 'style'],
+ th: ['width', 'rowspan', 'colspan', 'align', 'valign', 'style'],
+ tbody: ['align', 'valign', 'style'],
+ thead: ['align', 'valign', 'style'],
+ tfoot: ['align', 'valign', 'style'],
Review Comment:
I think we tried to add the styles here:
https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/utils/tooltip.ts,
but when we sanitized it, it then broke the spacing and formatting. If we
think what we did with theming could change how we redo tooltips, we should
probably implement it the correct way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
