korbit-ai[bot] commented on code in PR #34071: URL: https://github.com/apache/superset/pull/34071#discussion_r2185467951
########## superset/config.py: ########## @@ -1730,7 +1730,7 @@ def EMAIL_HEADER_MUTATOR( # pylint: disable=invalid-name,unused-argument # noq # Some sqlalchemy connection strings can open Superset to security risks. # Typically these should not be allowed. -PREVENT_UNSAFE_DB_CONNECTIONS = True +PREVENT_UNSAFE_DB_CONNECTIONS = False Review Comment: ### Confusing security setting with contradictory comment <sub></sub> <details> <summary>Tell me more</summary> ###### What is the issue? The comment explains a security feature but the code disables it without explaining why this is safe to do. ###### Why this matters The dissonance between the comment and the actual setting creates confusion and makes the code harder to understand. Future maintainers won't know if this is intentional or a mistake. ###### Suggested change ∙ *Feature Preview* Either update the comment to explain why it's safe to disable this security feature, or keep the setting as True. For example: ```python # Some sqlalchemy connection strings can open Superset to security risks. # This is disabled because [explanation of why it's safe in this context] PREVENT_UNSAFE_DB_CONNECTIONS = False ``` ###### Provide feedback to improve future suggestions [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/035a4688-38e0-4c28-b23a-7407ab48f615/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/035a4688-38e0-4c28-b23a-7407ab48f615?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/035a4688-38e0-4c28-b23a-7407ab48f615?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/035a4688-38e0-4c28-b23a-7407ab48f615?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/035a4688-38e0-4c28-b23a-7407ab48f615) </details> <sub> 💬 Looking for more details? Reply to this comment to chat with Korbit. </sub> <!--- korbi internal id:461a51c3-be5b-4ab1-ba3e-c0800502128e --> [](461a51c3-be5b-4ab1-ba3e-c0800502128e) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
