Re: [PR] fix(sqllab): ensure SQL_QUERY_MUTATOR is called when MUTATE_AFTER_SPLIT=True [superset]

Wed, 09 Jul 2025 02:55:02 -0700 


korbit-ai[bot] commented on code in PR #34111:
URL: https://github.com/apache/superset/pull/34111#discussion_r2194588320


##########
superset/sql_lab.py:
##########
@@ -475,7 +475,7 @@ def execute_sql_statements(  # noqa: C901
             db.session.commit()
 
             # Hook to allow environment-specific mutation (usually comments) 
to the SQL
-            query.executed_sql = database.mutate_sql_based_on_config(block)
+            query.executed_sql = database.mutate_sql_based_on_config(block, 
is_split=config["MUTATE_AFTER_SPLIT"])

Review Comment:
   ### Vague inline comment for SQL mutation <sub>![category 
Documentation](https://img.shields.io/badge/Documentation-7c3aed)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The comment is unclear about what 'environment-specific mutation' means and 
when it's used.
   
   
   ###### Why this matters
   Without understanding the purpose of SQL mutations, developers might 
accidentally break functionality when modifying this code.
   
   ###### Suggested change ∙ *Feature Preview*
   # Modify SQL based on environment configuration (e.g., add tracking 
comments, partitioning hints)
   query.executed_sql = database.mutate_sql_based_on_config(block, 
is_split=config["MUTATE_AFTER_SPLIT"])
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a9d4810c-2fc9-4ffa-ac88-2c734698e3fe/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a9d4810c-2fc9-4ffa-ac88-2c734698e3fe?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a9d4810c-2fc9-4ffa-ac88-2c734698e3fe?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a9d4810c-2fc9-4ffa-ac88-2c734698e3fe?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/a9d4810c-2fc9-4ffa-ac88-2c734698e3fe)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:468188bb-20cb-41a3-90de-0f7239afcdbd -->
   
   
   [](468188bb-20cb-41a3-90de-0f7239afcdbd)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to