kgabryje commented on code in PR #34017:
URL: https://github.com/apache/superset/pull/34017#discussion_r2194780253
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/utils.ts:
##########
@@ -190,3 +192,19 @@ export function getBuckets(
return buckets;
}
+
+export function getColorBreakpointsBuckets(fd: QueryFormData) {
Review Comment:
nit: maybe this function could accepts only the breakpoints as the argument
instead of the whole form data object? That way we might avoid some rerenders
caused by passing form data to a dependency array in useEffect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
