dosubot[bot] commented on issue #34076: URL: https://github.com/apache/superset/issues/34076#issuecomment-3052294599
<!-- Answer --> This is a known pain point with Playwright and SPA-style pages like Superset’s /login. The default wait_until='load' (or 'networkidle') can hang if there are lingering network requests or resources that never fully finish, which is common with modern frontend apps. That’s why 'domcontentloaded' works—it fires as soon as the initial HTML is parsed, regardless of outstanding resources or network activity. Increasing SCREENSHOT_PLAYWRIGHT_DEFAULT_TIMEOUT will only delay the error if the event never fires; it won’t fix the root cause if the page never reaches the 'load' or 'networkidle' state due to unresolved requests or frontend behavior. The best approach is to override the wait event to 'domcontentloaded' for problematic pages. You can do this globally by setting SCREENSHOT_PLAYWRIGHT_WAIT_EVENT = "domcontentloaded" in your config, or by customizing the auth driver as you did. This is the intended way to handle these cases in Superset’s Playwright integration, which is designed to be flexible and config-driven, but doesn’t auto-detect/fallback for you [cite](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/config.py) [cite](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/utils/webdriver.py). There’s no evidence of a recent frontend change that would have introduced this, and there’s no official recommendation in the codebase for which wait_until to use—it’s left to the deployer to pick what works best for their environment. Your workaround is the right move here. <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/f86374f5-9ef3-446a-bd23-b69f664aa88b?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/f86374f5-9ef3-446a-bd23-b69f664aa88b?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/f86374f5-9ef3-446a-bd23-b69f664aa88b?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/f86374f5-9ef3-446a-bd23-b69f664aa88b?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/f86374f5-9ef3-446a-bd23-b69f664aa88b?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/f86374f5-9ef3-446a-bd23-b69f664aa88b?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/f86374f5-9ef3-446a-bd23-b69f664aa88b?feedback_type=other)</sup> [](https://go.dosu.dev/discord-bot) [! [Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/34076) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
