Vitor-Avila commented on code in PR #34079: URL: https://github.com/apache/superset/pull/34079#discussion_r2195229907
########## superset-frontend/src/explore/components/PropertiesModal/PropertiesModal.test.tsx: ########## @@ -422,3 +419,28 @@ test('"Certification details" should not be empty when saved', async () => { ); }); }); + +test('Should display only custom tags when tagging system is enabled', async () => { + const mockIsFeatureEnabled = isFeatureEnabled as jest.MockedFunction< + typeof isFeatureEnabled + >; + mockIsFeatureEnabled.mockImplementation( + flag => flag === FeatureFlag.TaggingSystem, + ); + + const props = createProps(); + renderModal(props); + + await waitFor(() => { Review Comment: forgot to say that this is done now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org