mistercrunch commented on code in PR #34093:
URL: https://github.com/apache/superset/pull/34093#discussion_r2195689671
##########
superset/views/core.py:
##########
@@ -897,8 +896,6 @@ def fetch_datasource_metadata(self) -> FlaskResponse:
def welcome(self) -> FlaskResponse:
"""Personalized welcome page"""
if not g.user or not get_user_id():
- if conf["PUBLIC_ROLE_LIKE"]:
- return self.render_template("superset/public_welcome.html")
Review Comment:
Oh, yeah, I don't think I thought that through and @sadpandajoe merged.
Let's do a follow up PR to sort this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
