mistercrunch commented on code in PR #34115:
URL: https://github.com/apache/superset/pull/34115#discussion_r2195915174


##########
docs/docs/configuration/networking-settings.mdx:
##########
@@ -8,11 +8,11 @@ version: 1
 
 ## CORS
 
-To configure CORS, or cross-origin resource sharing, the following dependency 
must be installed:
 
-```python
-pip install apache_superset[cors]
-```
+:::note
+In Superset versions prior to `5.x` you have to install to install `flask-cors 
with` with `pip install apache-superset[cors]` to enable CORS support.

Review Comment:
   @betodealmeida mmmmh for this to be true I might need to keep that extra 
configured without using it .... or maybe i just instruct people to install 
flask-cors directly here 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to