justinpark commented on PR #34129: URL: https://github.com/apache/superset/pull/34129#issuecomment-3063154655
> Doesn't this disclose part of the (meta) data that is supposed to be forbidden again? I guess the real question is whether not being able to "access" a datasource should imply not being told any names / table names. The existing code's intent (and my expectation) seems to be that the desired result is not showing them (unless I overlooked them being in the response in some form anyway). The user does not lack permission to access the chart itself, but rather lacks permission to access the data source used in the chart. For example, when a user clicks on a chart from the chart list to view it, but does not have access to the dataset used by the chart, showing a message like "missing dataset" can be misleading. In other words, the user is unable to access information from the data source used in the chart (such as column information or table records), but being unable to even see the name of the dataset used in the chart makes it difficult to identify which source is causing the permission issue. In fact, within Airbnb, there are a significant number of inquiries about why a chart is not displaying properly and what the root cause is. To address this issue, it would be very helpful for users if the actual error message encountered when accessing the data source was displayed together with the current data source name. This would greatly assist users in troubleshooting the problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
