betodealmeida commented on code in PR #34140:
URL: https://github.com/apache/superset/pull/34140#discussion_r2201529766
##########
tests/unit_tests/db_engine_specs/test_doris.py:
##########
@@ -154,21 +206,29 @@ def test_get_schema_from_engine_params(
"database_value,expected_catalog",
[
("catalog1.schema1", "catalog1"),
- ("catalog1", "catalog1"),
Review Comment:
This test is wrong. If the URI has `catalog1` for the database, eg:
```
doris://user:pass@host/catalog1
```
Then `catalog1` is the schema ("database"), not the catalog. See
https://pypi.org/project/pydoris/.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
