mistercrunch opened a new pull request, #34146: URL: https://github.com/apache/superset/pull/34146
Trying to address the issue raise here: https://github.com/apache/superset/issues/34120#issuecomment-3058902853 From my analysis, it should address the issue (package installed twice in docker) by using a symlink. The downsides are pretty minimal, with a micro os-level penalty on resolving symlinks (super minimal from my understanding), and some considerations around image size, where in editable mode we can't/couldn't strip .py files if we wanted. This seems like a positive step. Other alternatives would probably require 2 extra layers (an extra build layer for both dev and lean), and it's hard to keep the docker logic DRY and readable in that context. Personally I'm not willing to take this on now... With this approach, we wouldn't have `/app/superset` and would only have superset/ in `.venv`, could compile and strip `.py` to only keep `.pyc` if we wanted there. Doing some research, it seems python is still very much lacking around managing lean packages of bytecode only, where wheels and packages in general tend to be raw .py, and it's tricky to only pacakge .pyc if/when desired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
