betodealmeida opened a new pull request, #34180: URL: https://github.com/apache/superset/pull/34180
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The Databricks SQLAlchemy dialect we use has a bug when escaping single quotes: it doubles the single quote, instead of using a backslash. For example, a value of `O'Hara` will be rendered in the SQL as `O''Hara`, which is correct for most databases, but for Databricks should be `O\'Hara`. Upgrading to the latest `databricks-sqlalchemy` package fixes the issue, but requires SQLAlchemy 2.x. The 1.x line of `databricks-sqlalchemy` has the bug as well. Note, we're using the unnoficial `sqlalchemy-databricks` package instead, so we should consider changing a 1.x version of the official one. For now, this PR solves the problem by monkeypatching a custom string escaper into the the dialect. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
